chore: warn about the usage of deprecated cli arguments MCP-107 #493
+68
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds functionality to warn users about deprecated CLI arguments, specifically targeting the --connectionString argument. The change encourages users to adopt the preferred method of using positional arguments or environment variables for connection strings.
- Implements a new
warnAboutDeprecatedCliArgsfunction that checks for deprecated CLI arguments and issues warnings - Integrates the warning system into the CLI config parsing flow
- Adds comprehensive unit tests to verify the deprecation warning behavior
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/common/config.ts | Adds the warnAboutDeprecatedCliArgs function and integrates it into CLI parsing |
| tests/unit/common/config.test.ts | Adds unit tests for the deprecated CLI argument warning functionality |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
gagik
reviewed
Aug 29, 2025
gagik
approved these changes
Sep 1, 2025
Pull Request Test Coverage Report for Build 17373727595Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist